CST 338: Week 3
- Summarize the feedback you received about your code from your peers
Sydney: The variable names in my code are good and self-explanatory. The conditional flow in my takeDamage() method can benefit from being rearranged or rewritten to improve clarity. All the imports of my code are utilized and there are no warnings. My formatting is clear and consists of nice structure and spacing.
Alexander: The variable names in my code are meaningful and clear. The logic is good and flows through the methods properly. No warning or unused imports are present. My code consists of clear formatting, great spacing, and proper indentation. Javadocs are clear and present for all methods.
- Identify any trends you noticed when evaluating the code of others
- such as: everyone struggled with sorting or unit tests that were hard to pass
Both Sydney and Alexander had a tendency to utilize the keyword 'this' throughout their code when it wasn't entirely necessary. I was led to believe that the 'this' keyword should only be used when there is another object of the same type or if there are variables that are passed in with similar names as those within an object.
- Was any part of the code a struggle for YOU?
Writing the comments is typically difficult for me due to a lack of practice throughout other classes. I've developed a habit of writing code from logic established in my head rather than taking the time to write out the logic.
- Was any part of writing the code easy for YOU?
I was able to write out the classes and define all of their variables and methods within a couple of hours
- What is your biggest victory?
I would say my biggest victory was getting the tests to pass within my first few revisions of my code.
Comments
Post a Comment